remove delegate_to
configuration option from our DSL
#3086
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In our initial discussion, we agreed that the
delegate_to
option's main functionality was not to cache the result when configuring. For that reason, renaming it tocache
would express with more accuracy the intent of the option.I started by renaming it, but after seeing how much the option code has evolved since the initial conversation with the introduction of precedence, parsing env vars, etc... While trying to rename it to
cache
I realized that it would be more complicated than it seems, more importantly we have no idea how an option would work usingdelegate_to
in the current system.For the reason outlined above I think is best to remove the option since no configuration definition is using it, and if we ever want to introduce the ability to configure if an option is cached we could do it in the future, hopefully with some requirements defined.
Motivation:
Additional Notes:
How to test the change?
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance
.Unsure? Have a question? Request a review!