Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make racecar traces use the default service name #2776

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Make racecar traces use the default service name #2776

wants to merge 3 commits into from

Commits on Apr 12, 2023

  1. Make racecar traces use the default service name 

    Right now, if no `service_name` is specified for a `racecar` trace, the default will not come from the `DD_SERVICE` env var, but will rather be the static string `"racecar"`. This seems like a poor default, assuming an organization runs more than one consumer.
    @dasch
    dasch authored Apr 12, 2023
    Configuration menu
    Copy the full SHA
    621adee View commit details
    Browse the repository at this point in the history

  2. Fix the spec as well

    @dasch
    dasch authored Apr 12, 2023
    Configuration menu
    Copy the full SHA
    4054a4e View commit details
    Browse the repository at this point in the history

  3. Remove constant containing service name

    @dasch
    dasch authored Apr 12, 2023
    Configuration menu
    Copy the full SHA
    81d5b2f View commit details
    Browse the repository at this point in the history