Omit _dd.span_sampling.max_per_second when not configured
#2715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delner
reviewed
Mar 24, 2023
| @@ -22,7 +22,7 @@ class Rule | |||
| def initialize( | |||
| matcher, | |||
| sample_rate: Span::Ext::DEFAULT_SAMPLE_RATE, | |||
| rate_limit: Span::Ext::DEFAULT_MAX_PER_SECOND | |||
| rate_limit: nil | |||
There was a problem hiding this comment.
Interesting. Why demote this from constructor args to constructor body?
There was a problem hiding this comment.
I need to know when rate_limit was not set (thus nil).
Before, it would fall back to the default unlimited value -1, but then I can't tell if the user has explicitly set -1 or not set anything at all.
We only want to remove the span_op.set_metric(Span::Ext::TAG_MAX_PER_SECOND, ... tag if the user did not provide a rate_limit.
GustavoCaso
reviewed
May 19, 2023
| @@ -406,7 +406,7 @@ def agent_receives_span_step3(previous_success) | |||
| it do | |||
| expect(single_sampled_span.get_metric('_dd.span_sampling.mechanism')).to eq(8) | |||
| expect(single_sampled_span.get_metric('_dd.span_sampling.rule_rate')).to eq(1.0) | |||
| expect(single_sampled_span.get_metric('_dd.span_sampling.max_per_second')).to eq(-1) | |||
There was a problem hiding this comment.
Should we add test that checks that _dd.span_sampling.max_per_second is set when rate_limit is provided?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Single Span Sampling, when no rate limit is provided, we should not include the
_dd.span_sampling.max_per_second.Before this PR,
_dd.span_sampling.max_per_secondwas included with a default value of-1, meaning unlimited.After this PR,
_dd.span_sampling.max_per_secondwill be omitted when not configured. The backend will assume an unlimited rate for such cases.This fixes an inconsistency we had with the Single Span Sampling specification.