Simplify macOS testing matrix #2653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What does this PR do?**: This PR changes the `Test macOS` github action to only use the latest macOS for testing, rather than testing with multiple versions of macOS. **Motivation**: We don't currently support macOS on production environments, as documented in <https://github.com/DataDog/dd-trace-rb/blob/master/docs/GettingStarted.md#apple-macos-support> It's still valuable to "keep an eye on" macOS, since we do want to be able to use it in development. BUT our test matrix is rather complex, so I think not testing older macOS versions * 10 Ruby versions we support is a worthy simplification. Additionally, once github adds support for macOS 13, we'll automatically start testing on that one as well, which should match what most macOS-based developers are using. **Additional Notes**: N/A **How to test the change?**: Validate that the `Test macOS` github action still runs, but only on macos-latest (macOS 12), and does not run on macOS 11.
github-actions
bot
added
the
dev/github
TonyCTHsu
approved these changes
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
This PR changes the
Test macOSgithub action to only use the latest macOS for testing, rather than testing with multiple versions of macOS.Motivation:
We don't currently support macOS on production environments, as documented in
https://github.com/DataDog/dd-trace-rb/blob/master/docs/GettingStarted.md#apple-macos-support
It's still valuable to "keep an eye on" macOS, since we do want to be able to use it in development.
BUT our test matrix is rather complex, so I think not testing older macOS versions * 10 Ruby versions we support is a worthy simplification.
Additionally, once github adds support for macOS 13, we'll automatically start testing on that one as well, which should match what most macOS-based developers are using.
Additional Notes:
N/A
How to test the change?:
Validate that the
Test macOSgithub action still runs, but only on macos-latest (macOS 12), and does not run on macOS 11.