Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds span.kind:client for dalli #2619

Merged
merged 1 commit into from
Feb 15, 2023
Merged

Adds span.kind:client for dalli #2619

merged 1 commit into from
Feb 15, 2023

Conversation

zarirhamza
Copy link
Contributor

What does this PR do?
Adds span.kind:client for dalli

Motivation
Unify span tags across tracers

@zarirhamza zarirhamza requested a review from a team February 14, 2023 18:24
@github-actions github-actions bot added integrations Involves tracing integrations tracing labels Feb 14, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #2619 (89786ea) into master (8022e0e) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2619      +/-   ##
==========================================
- Coverage   98.01%   98.01%   -0.01%     
==========================================
  Files        1148     1148              
  Lines       62423    62454      +31     
  Branches     2808     2808              
==========================================
+ Hits        61186    61215      +29     
- Misses       1237     1239       +2     
Impacted Files Coverage Δ
...b/datadog/tracing/contrib/dalli/instrumentation.rb 100.00% <100.00%> (ø)
...dog/profiling/collectors/cpu_and_wall_time_spec.rb 97.58% <100.00%> (-0.31%) ⬇️
...filing/collectors/cpu_and_wall_time_worker_spec.rb 94.77% <100.00%> (+0.05%) ⬆️
spec/datadog/profiling/collectors/stack_spec.rb 97.29% <100.00%> (ø)
spec/datadog/profiling/spec_helper.rb 95.12% <100.00%> (+0.25%) ⬆️
spec/datadog/profiling/stack_recorder_spec.rb 100.00% <100.00%> (ø)
...adog/tracing/contrib/dalli/instrumentation_spec.rb 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@GustavoCaso GustavoCaso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@marcotc marcotc merged commit ba7fd9c into master Feb 15, 2023
@marcotc marcotc deleted the zarir/dalli-spankind branch February 15, 2023 21:25
@github-actions github-actions bot added this to the 1.10.0 milestone Feb 15, 2023
@TonyCTHsu TonyCTHsu mentioned this pull request Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrations Involves tracing integrations tracing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants