Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mandatory tags for rabbitmq integrations #2613

Merged
merged 1 commit into from
Feb 13, 2023

Conversation

rarguelloF
Copy link
Contributor

What does this PR do?

Adds the mandatory tag messaging.rabbitmq.routing_key for rabbitmq integrations (only sneakers).

Motivation

Unify span tags across tracers.

Additional Notes

How to test the change?

Updated unit tests.

@github-actions github-actions bot added integrations Involves tracing integrations tracing labels Feb 10, 2023
@rarguelloF rarguelloF marked this pull request as ready for review February 10, 2023 15:19
@rarguelloF rarguelloF requested a review from a team February 10, 2023 15:19
@codecov-commenter
Copy link

Codecov Report

Merging #2613 (fd5b865) into master (e078c25) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2613      +/-   ##
==========================================
- Coverage   98.02%   98.02%   -0.01%     
==========================================
  Files        1148     1148              
  Lines       62357    62357              
  Branches     2806     2806              
==========================================
- Hits        61126    61125       -1     
- Misses       1231     1232       +1     
Impacted Files Coverage Δ
lib/datadog/tracing/contrib/ext.rb 100.00% <100.00%> (ø)
lib/datadog/tracing/contrib/sneakers/tracer.rb 100.00% <100.00%> (ø)
...ec/datadog/tracing/contrib/sneakers/tracer_spec.rb 100.00% <100.00%> (ø)
lib/datadog/core/diagnostics/environment_logger.rb 97.69% <0.00%> (-1.57%) ⬇️
...ng/contrib/active_support/cache/instrumentation.rb 86.30% <0.00%> (+0.09%) ⬆️
...ec/datadog/tracing/contrib/sidekiq/patcher_spec.rb 100.00% <0.00%> (+4.00%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@zarirhamza zarirhamza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcotc marcotc merged commit c20bb9e into master Feb 13, 2023
@marcotc marcotc deleted the rarguelloF/add-rabbitmq-tags branch February 13, 2023 20:45
@github-actions github-actions bot added this to the 1.10.0 milestone Feb 13, 2023
@TonyCTHsu TonyCTHsu mentioned this pull request Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrations Involves tracing integrations tracing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants