[distributed tracing] disabling tracer disables distributed headers #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ufoot
commented
Nov 23, 2017
| @@ -28,7 +28,7 @@ def initialize(app, options = {}) | |||
| def call(env) | |||
| dd_pin.tracer.trace(SERVICE) do |span| | |||
| annotate!(span, env) | |||
| propagate!(span, env) if options[:distributed_tracing] | |||
| propagate!(span, env) if options[:distributed_tracing] && dd_pin.tracer.enabled | |||
There was a problem hiding this comment.
I think the test should wait for the merge of #229 and more precisely the introduction of WebMock https://github.com/DataDog/dd-trace-rb/pull/229/files#diff-b06e29a984e208fededfd0c6e60ca9ecR41 which could be very useful and straightforward to write a simple test for this.
There was a problem hiding this comment.
What test should we write?
When the tracer is disabled, the traces/spans are not sent, so we should not set the distributed tracing headers, else children called with these would refer to non-existing (never sent) parent traces.
p-lambert
force-pushed
the
christian/noprioritywhendisabled
branch
from
5d58222
to
70f018f
Compare
p-lambert
previously approved these changes
Nov 28, 2017
p-lambert
force-pushed
the
christian/noprioritywhendisabled
branch
from
70f018f
to
d0f1828
Compare
palazzem
approved these changes
Nov 29, 2017
palazzem
reviewed
Nov 29, 2017
| if span.context.sampling_priority | ||
| req.add_field( | ||
| Datadog::Ext::DistributedTracing::HTTP_HEADER_SAMPLING_PRIORITY, | ||
| span.context.sampling_priority |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the tracer is disabled, the traces/spans are not sent, so we
should not set the distributed tracing headers, else children called
with these would refer to non-existing (never sent) parent traces.