Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a
type
field toOptionDefinition
, which can be used to identify what kind of value the option should hold.It also adds
type
tosettings
via to itsOptionDefinition
.type
contains the auto-generated class used to encapsulate the option definitions contained withinsettings
. Exposing this class allows you to metaprogram against an existingsettings
, such as adding or modifying option definitions.Motivation
type
allow for more descriptive option definitions, possibly type checking/coercion features later.When creating
settings
options using the configuration DSL, it auto-generates an appropriate class with configuration behavior loaded. This class was entirely inaccessible, unless you instantiate thesettings
and its default value. Exposingtype
makes this class accessible without hacks.Additional Notes
Also did a minor expansion on tests to encompass a bit more of the pre-existing behavior (adding coverage).