Create priority sampler feedback loop #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-lambert
changed the base branch from
christian/service-sampler
to
pedro/service-sampler
p-lambert
force-pushed
the
pedro/enable-distributed-sampling-on-transport
branch
2 times, most recently
from
548c403
to
f73cc15
Compare
ufoot
reviewed
Nov 20, 2017
| @@ -20,30 +20,35 @@ class HTTPTransport | |||
| RUBY_INTERPRETER = RUBY_VERSION > '1.9' ? RUBY_ENGINE + '-' + RUBY_PLATFORM : 'ruby-' + RUBY_PLATFORM | |||
|
|
|||
| API = { | |||
| 'v0.3' => { | |||
| V4 = 'v0.4'.freeze => { | |||
| @@ -176,5 +183,15 @@ def stats | |||
| } | |||
| end | |||
| end | |||
|
|
|||
| private | |||
test/writer_test.rb
Outdated
| def test_sampling_feedback_loop | ||
| sampler = Minitest::Mock.new | ||
| writer = Writer.new(priority_sampler: sampler) | ||
| response_body = { 'service_a' => 0.1, 'service_b' => 0.5 }.to_json |
There was a problem hiding this comment.
Real-world responses are more like:
{ 'service:,env:' => 0.1, 'service:a,env:test' => 0.3, 'service:b,env:test' => 0.15 }
while, technically, it's perfectly fine to test it with the entry you used, I also think it's good that the test data, be it mocked, actually reflect real use cases, so it would be nice to have at least one test that has real data (or at least, data that is technically likely to happen). On the agent you get hints on this here https://github.com/DataDog/datadog-trace-agent/blob/master/sampler/catalog_test.go#L66 or there https://github.com/DataDog/datadog-trace-agent/blob/master/agent/info_test.go#L107
p-lambert
force-pushed
the
pedro/enable-distributed-sampling-on-transport
branch
from
f73cc15
to
82c9628
Compare
p-lambert
force-pushed
the
pedro/enable-distributed-sampling-on-transport
branch
from
82c9628
to
1c3cda0
Compare
palazzem
approved these changes
Nov 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides the feedback loop between the
datadog-trace-agentand thePrioritySampler. The purpose of it is to adjust dynamically the sampling rates of each service after each flush.