Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PROF-6559] Mark Ruby CPU Profiling 2.0 as being in beta #2489

Merged
merged 2 commits into from
Dec 14, 2022

Conversation

ivoanjo
Copy link
Member

@ivoanjo ivoanjo commented Dec 13, 2022

What does this PR do?:

This PR collects a few small changes needed before releasing the new Ruby profiler bits ("CPU Profiling 2.0") as opt-in (that is, disabled by default) public beta.

I recommend reviewing commit-by-commit.

Motivation:

We're finally ready to start telling customers they can enable this new mode.

Additional Notes:

(N/A)

How to test the change?:

Change includes test coverage (the little code that is affected).

@github-actions github-actions bot added core Involves Datadog core libraries profiling Involves Datadog profiling labels Dec 13, 2022
@ivoanjo ivoanjo changed the title (WORK IN PROGRESS DRAFT) [PROF-6559] Mark Ruby CPU Profiling 2.0 as being in beta [PROF-6559] Mark Ruby CPU Profiling 2.0 as being in beta Dec 14, 2022
@ivoanjo ivoanjo marked this pull request as ready for review December 14, 2022 09:07
@ivoanjo ivoanjo requested a review from a team December 14, 2022 09:07
@codecov-commenter
Copy link

Codecov Report

Merging #2489 (91cc4c5) into master (ec7b868) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2489   +/-   ##
=======================================
  Coverage   98.32%   98.32%           
=======================================
  Files        1118     1120    +2     
  Lines       60351    60401   +50     
=======================================
+ Hits        59339    59390   +51     
+ Misses       1012     1011    -1     
Impacted Files Coverage Δ
lib/datadog/core/configuration/components.rb 98.92% <ø> (ø)
...tadog/profiling/collectors/idle_sampling_helper.rb 93.54% <ø> (ø)
spec/datadog/core/configuration/components_spec.rb 100.00% <ø> (ø)
lib/datadog/profiling.rb 100.00% <100.00%> (ø)
...adog/profiling/collectors/dynamic_sampling_rate.rb 100.00% <100.00%> (ø)
...profiling/collectors/dynamic_sampling_rate_spec.rb 100.00% <100.00%> (ø)
spec/datadog/profiling/native_extension_spec.rb 98.11% <0.00%> (-0.63%) ⬇️
...ng/contrib/active_support/cache/instrumentation.rb 87.67% <0.00%> (+0.08%) ⬆️
lib/datadog/core/diagnostics/environment_logger.rb 99.21% <0.00%> (+0.78%) ⬆️
lib/datadog/core/workers/polling.rb 100.00% <0.00%> (+3.44%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ivoanjo ivoanjo merged commit fd88411 into master Dec 14, 2022
@ivoanjo ivoanjo deleted the ivoanjo/prof-6559-cpu-profiling-2-beta branch December 14, 2022 15:17
@github-actions github-actions bot added this to the 1.8.0 milestone Dec 14, 2022
@ivoanjo ivoanjo restored the ivoanjo/prof-6559-cpu-profiling-2-beta branch December 15, 2022 22:00
@GustavoCaso GustavoCaso deleted the ivoanjo/prof-6559-cpu-profiling-2-beta branch October 11, 2023 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Involves Datadog core libraries profiling Involves Datadog profiling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants