Improve redis integration patching #2470
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Until
redis
4, all instrumentation happened in one gem:redis
. Sinceredis
5, instrumentation happens in a separate gem:redis-client
. Becauseredis
4 does not depend onredis-client
, it's possible for both gems to be installed at the same time.For example, if
sidekiq
7 andredis
4 are installed: bothredis
andredis-client
will be installed.This implementation improves the patching condition to apply to whenever it is possible.
PS. The minimun
redis-client
supported would be0.11.0
, whereConfig#custom
is implemented.