Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes error.msg to error.message for UNC #2469

Merged
merged 2 commits into from
Dec 6, 2022
Merged

Conversation

zarirhamza
Copy link
Contributor

What does this PR do?

Renames the error.msg tag to error.message tag in order to meet the requirements of naming across all tracers.

@zarirhamza zarirhamza requested a review from a team December 6, 2022 16:50
@delner
Copy link
Contributor

delner commented Dec 6, 2022

Seems simple enough! Just to be sure, does Datadog ingest this tag properly for errors? Just want to make sure its supported downstream before we change behavior.

@zarirhamza
Copy link
Contributor Author

Seems simple enough! Just to be sure, does Datadog ingest this tag properly for errors? Just want to make sure its supported downstream before we change behavior.

Yup! All these tag changes have been approved by the backend to change.

@TonyCTHsu TonyCTHsu merged commit b23c1d5 into master Dec 6, 2022
@TonyCTHsu TonyCTHsu deleted the zarir/error_message branch December 6, 2022 21:52
@github-actions github-actions bot added this to the 1.8.0 milestone Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants