Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extra testing from W3C spec #2460

Merged
merged 2 commits into from
Dec 5, 2022
Merged

Extra testing from W3C spec #2460

merged 2 commits into from
Dec 5, 2022

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Dec 3, 2022

I looked at our internal RFC and found a few cases where we could process invalid traceparent headers:

  1. Hex integers that are too large or too small are not allowed.
  2. Trailing whitespace is allowed.

@marcotc marcotc requested a review from a team December 3, 2022 01:24
ivoanjo
ivoanjo approved these changes Dec 5, 2022
View reviewed changes
Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

spec/datadog/tracing/distributed/trace_context_spec.rb Outdated Show resolved Hide resolved
Base automatically changed from w3c-wire to master December 5, 2022 23:36
@marcotc marcotc merged commit 272af07 into master Dec 5, 2022
@marcotc marcotc deleted the w3c-more-testing branch December 5, 2022 23:48
@github-actions github-actions bot added this to the 1.8.0 milestone Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivoanjo ivoanjo ivoanjo approved these changes

Assignees
No one assigned
Labels
tracing
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@marcotc @ivoanjo