Add W3C Trace Context propagator #2451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcotc
commented
Nov 30, 2022
Comment on lines
+88
to
+97
| # Check if the Priority Sampling decision is to keep or drop the trace. | ||
| # Other factors can influence the sampling decision; this method is only | ||
| # responsible for interpreting the Sampling Priority decision. | ||
| # | ||
| # @param priority_sampling [Integer] priority sampling number | ||
| # @return [Boolean] true if trace is "kept" by priority sampling | ||
| # @return [Boolean] false if trace is "dropped" by priority sampling | ||
| def self.sampled?(priority_sampling) | ||
| priority_sampling >= Ext::Priority::AUTO_KEEP | ||
| end |
There was a problem hiding this comment.
I got tired of obscure sampling comparisons all over ddtrace, like sampling_priority > AUTO_KEEP or sampling_priority <= AUTO_KEEP. It's never clear what they mean.
I added this so we can start cleaning up such checks all over ddtrace now.
Codecov Report
@@ Coverage Diff @@
## master #2451 +/- ##
========================================
Coverage 98.34% 98.34%
========================================
Files 1101 1103 +2
Lines 58977 59338 +361
========================================
+ Hits 58001 58357 +356
- Misses 976 981 +5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
TonyCTHsu
approved these changes
Dec 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support trace propagation through the the "W3C Trace Context": https://www.w3.org/TR/trace-context/.
This standard is used by OpenTelemetry to propagate traces by default.
This PR adds the propagator class but does not wire it yet, as to make this PR smaller to review.