Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis 5 Instrumentation #2428

Merged
merged 21 commits into from
Dec 2, 2022
Merged

Redis 5 Instrumentation #2428

merged 21 commits into from
Dec 2, 2022

Conversation

TonyCTHsu
Copy link
Contributor

@TonyCTHsu TonyCTHsu commented Nov 25, 2022

What does this PR do?

Instrument Redis 5

** Notable changes **

Before

customer_cache = Redis.new
invoice_cache = Redis.new

Datadog.configure_onto(customer_cache, service_name: 'customer-cache')
Datadog.configure_onto(invoice_cache, service_name: 'invoice-cache')

customer_cache.get(...)
invoice_cache.get(...)

After

customer_cache = Redis.new(custom: { datadog: { service_name: 'custom-cache' } })
invoice_cache = Redis.new(custom: { datadog: { service_name: 'invoice-cache' } })

customer_cache.get(...)
invoice_cache.get(...)

#2373

@github-actions github-actions bot added integrations Involves tracing integrations tracing labels Nov 25, 2022
@TonyCTHsu TonyCTHsu force-pushed the feature/redis-5-instrumentation branch 2 times, most recently from c72640a to 16ae8a4 Compare November 26, 2022 01:34
@TonyCTHsu TonyCTHsu force-pushed the feature/redis-5-instrumentation branch from 16ae8a4 to 423c148 Compare November 28, 2022 12:36
@TonyCTHsu TonyCTHsu force-pushed the feature/redis-5-instrumentation branch from 423c148 to 70f7826 Compare November 28, 2022 14:33
@TonyCTHsu TonyCTHsu force-pushed the feature/redis-5-instrumentation branch from b3d4c9a to ef48ff2 Compare November 28, 2022 20:27
@TonyCTHsu TonyCTHsu force-pushed the feature/redis-5-instrumentation branch from ef48ff2 to 19e9e98 Compare November 28, 2022 20:39
@TonyCTHsu TonyCTHsu marked this pull request as ready for review November 28, 2022 21:10
@TonyCTHsu TonyCTHsu requested a review from a team November 28, 2022 21:10
docs/GettingStarted.md Outdated Show resolved Hide resolved
docs/GettingStarted.md Outdated Show resolved Hide resolved
docs/GettingStarted.md Outdated Show resolved Hide resolved
TonyCTHsu and others added 2 commits November 29, 2022 13:44
Co-authored-by: Marco Costa <marco.costa@datadoghq.com>
@TonyCTHsu TonyCTHsu merged commit 955b504 into master Dec 2, 2022
@TonyCTHsu TonyCTHsu deleted the feature/redis-5-instrumentation branch December 2, 2022 13:29
@github-actions github-actions bot added this to the 1.8.0 milestone Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrations Involves tracing integrations tracing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants