Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds 'span.kind' tag for 'kafka' #2420

Merged
merged 1 commit into from
Nov 23, 2022
Merged

Adds 'span.kind' tag for 'kafka' #2420

merged 1 commit into from
Nov 23, 2022

Conversation

zarirhamza
Copy link
Contributor

@zarirhamza zarirhamza commented Nov 23, 2022 •
edited
Loading

What does this PR do?
Adds span.kind tag for integrations kafka

Refer to Opentelemetry for definitions of consumer and producer

The producer and produce_operations files enqueues jobs in an asynchronous manner meaning that it gets the producer value for span.kind
The consumer_event super class completes jobs in an asynchronous manner meaning that it gets the consumer value for span.kind

@zarirhamza zarirhamza requested a review from a team November 23, 2022 23:02
@github-actions github-actions bot added integrations Involves tracing integrations tracing labels Nov 23, 2022
@marcotc marcotc merged commit 15dafb0 into master Nov 23, 2022
@marcotc marcotc deleted the zarir/span_kind_kafka branch November 23, 2022 23:26
@github-actions github-actions bot added this to the 1.7.0 milestone Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcotc marcotc marcotc approved these changes

Assignees
No one assigned
Labels
integrations Involves tracing integrations tracing
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@zarirhamza @marcotc