Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds span.kind with values producer and consumer for delayed_job #2393

Merged
merged 2 commits into from
Nov 22, 2022

Conversation

zarirhamza
Copy link
Contributor

What does this PR do?

Adds span.kind tag for certain spans in delayed_job

Refer to Opentelemetry for definitions of producer and consumer

The instrument_invoke method has been tagged with consumer for span.kind
The instrument_enqueue method has been tagged with producer for span.kind

@zarirhamza zarirhamza requested a review from a team November 22, 2022 17:29
@github-actions github-actions bot added integrations Involves tracing integrations tracing labels Nov 22, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #2393 (d1e7021) into master (a6a1bc5) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head d1e7021 differs from pull request most recent head a8aebd6. Consider uploading reports for the commit a8aebd6 to get more accurate results

@@            Coverage Diff             @@
##           master    #2393      +/-   ##
==========================================
- Coverage   98.35%   98.35%   -0.01%     
==========================================
  Files        1102     1102              
  Lines       59374    59389      +15     
==========================================
+ Hits        58397    58411      +14     
- Misses        977      978       +1     
Impacted Files Coverage Δ
...b/datadog/tracing/contrib/redis/instrumentation.rb 100.00% <100.00%> (ø)
...adog/tracing/contrib/redis/instrumentation_spec.rb 100.00% <100.00%> (ø)
spec/datadog/tracing/contrib/redis/miniapp_spec.rb 100.00% <100.00%> (ø)
spec/datadog/tracing/contrib/redis/redis_spec.rb 99.53% <100.00%> (+0.02%) ⬆️
spec/support/http_helpers.rb 90.90% <0.00%> (-9.10%) ⬇️
lib/datadog/core/diagnostics/environment_logger.rb 98.42% <0.00%> (-1.58%) ⬇️
...adog/tracing/contrib/sidekiq/server_tracer_spec.rb 100.00% <0.00%> (+0.83%) ⬆️
...adog/tracing/contrib/sidekiq/client_tracer_spec.rb 100.00% <0.00%> (+2.08%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@TonyCTHsu TonyCTHsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TonyCTHsu TonyCTHsu merged commit 4715777 into master Nov 22, 2022
@TonyCTHsu TonyCTHsu deleted the zarir/delayed_job_span_kind branch November 22, 2022 21:21
@github-actions github-actions bot added this to the 1.7.0 milestone Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrations Involves tracing integrations tracing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants