Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix frozen input for Redis #2370

Merged
merged 4 commits into from
Nov 16, 2022
Merged

Conversation

TonyCTHsu
Copy link
Contributor

#2369

What does this PR do?

FrozenError, when user provide a frozen hash to Redis.

Instead of mutating the input hash, use Hash#merge to return a new hash.

@TonyCTHsu TonyCTHsu requested a review from a team November 16, 2022 08:51
@TonyCTHsu TonyCTHsu self-assigned this Nov 16, 2022
@github-actions github-actions bot added integrations Involves tracing integrations tracing labels Nov 16, 2022
Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

lib/datadog/tracing/contrib/redis/patcher.rb Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #2370 (235abe9) into master (4114496) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2370      +/-   ##
==========================================
- Coverage   98.34%   98.33%   -0.02%     
==========================================
  Files        1101     1101              
  Lines       58940    58943       +3     
==========================================
- Hits        57967    57960       -7     
- Misses        973      983      +10     
Impacted Files Coverage Δ
lib/datadog/tracing/contrib/redis/patcher.rb 100.00% <100.00%> (ø)
...adog/tracing/contrib/redis/instrumentation_spec.rb 100.00% <100.00%> (ø)
...dog/tracing/contrib/redis/integration_test_spec.rb 100.00% <100.00%> (ø)
spec/datadog/tracing/contrib/redis/miniapp_spec.rb 100.00% <100.00%> (ø)
spec/datadog/tracing/contrib/redis/redis_spec.rb 99.51% <100.00%> (+<0.01%) ⬆️
...ontrib/sidekiq/server_internal_tracer/heartbeat.rb 36.00% <0.00%> (-28.00%) ⬇️
spec/support/synchronization_helpers.rb 81.57% <0.00%> (-2.64%) ⬇️
lib/datadog/core/diagnostics/environment_logger.rb 98.42% <0.00%> (-1.58%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@TonyCTHsu TonyCTHsu changed the base branch from master to 1.6-stable November 16, 2022 19:14
@TonyCTHsu TonyCTHsu merged commit 038f210 into 1.6-stable Nov 16, 2022
@TonyCTHsu TonyCTHsu deleted the tonycthsu/fix-frozen-input-for-redis branch November 16, 2022 19:27
@TonyCTHsu TonyCTHsu added this to the 1.6.1 milestone Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrations Involves tracing integrations tracing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants