Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified tagging span.kind as server and client #2365

Merged
merged 6 commits into from
Nov 17, 2022

Conversation

zarirhamza
Copy link
Contributor

What does this PR do?

Unified tagging span.kind as server and client, inspired by Opentelemetry

@zarirhamza zarirhamza added the do-not-merge/WIP Not ready for merge label Nov 14, 2022
@github-actions github-actions bot added integrations Involves tracing integrations tracing labels Nov 14, 2022
@marcotc
Copy link
Member

marcotc commented Nov 14, 2022

👋 @TonyCTHsu, you working on similar initiatives, can you please take a look at this PR?

@zarirhamza zarirhamza removed the do-not-merge/WIP Not ready for merge label Nov 15, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #2365 (74d982b) into master (af16512) will decrease coverage by 0.02%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master    #2365      +/-   ##
==========================================
- Coverage   98.34%   98.32%   -0.03%     
==========================================
  Files        1102     1102              
  Lines       58929    59027      +98     
==========================================
+ Hits        57954    58037      +83     
- Misses        975      990      +15     
Impacted Files Coverage Δ
lib/datadog/core/configuration/settings.rb 97.51% <ø> (ø)
...filing/collectors/cpu_and_wall_time_worker_spec.rb 91.19% <71.42%> (-8.81%) ⬇️
...g/profiling/collectors/cpu_and_wall_time_worker.rb 97.14% <100.00%> (ø)
...tracing/contrib/grpc/datadog_interceptor/server.rb 95.55% <100.00%> (+0.10%) ⬆️
lib/datadog/tracing/contrib/mongodb/subscribers.rb 96.87% <100.00%> (+0.04%) ⬆️
lib/datadog/tracing/contrib/rack/middlewares.rb 99.23% <100.00%> (+0.01%) ⬆️
spec/datadog/profiling/native_extension_spec.rb 97.87% <100.00%> (+0.37%) ⬆️
...ng/contrib/grpc/datadog_interceptor/server_spec.rb 100.00% <100.00%> (ø)
...pec/datadog/tracing/contrib/mongodb/client_spec.rb 99.65% <100.00%> (+<0.01%) ⬆️
...adog/tracing/contrib/rack/integration_test_spec.rb 100.00% <100.00%> (ø)
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zarirhamza zarirhamza marked this pull request as ready for review November 16, 2022 20:22
@zarirhamza zarirhamza requested a review from a team November 16, 2022 20:22
@TonyCTHsu TonyCTHsu merged commit ade3d37 into master Nov 17, 2022
@TonyCTHsu TonyCTHsu deleted the zarir/spankind-server-client branch November 17, 2022 08:56
@github-actions github-actions bot added this to the 1.7.0 milestone Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrations Involves tracing integrations tracing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants