Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis 6.2 image for CI #2364

Merged
merged 4 commits into from
Nov 11, 2022
Merged

Redis 6.2 image for CI #2364

merged 4 commits into from
Nov 11, 2022

Conversation

TonyCTHsu
Copy link
Contributor

@TonyCTHsu TonyCTHsu commented Nov 10, 2022

What does this PR do?

Use Redis 6.2 image for CI. This would allow us to gradually testing newer gem version of redis and sidekiq

  1. Align the images used for CI and development. 6.2 for new versions of redis and 3.0 for older version.
  2. Since qless is having issues with newer versions of redis. Establish a new old redis container for it. We should move qless to contrib-old in future. Because the gem is not actively maintained and has a couple of dependencies that are blocking other gems in the same appraisal group.
  3. Fixing failing spec, due to slightly different error message from DB redis.

@TonyCTHsu TonyCTHsu self-assigned this Nov 10, 2022
@TonyCTHsu TonyCTHsu force-pushed the tonycthsu/fix-redis-spec branch 2 times, most recently from afe8d19 to d7e0ebc Compare November 10, 2022 15:04
@codecov-commenter
Copy link

codecov-commenter commented Nov 10, 2022

Codecov Report

Merging #2364 (86ec11b) into master (b478593) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2364   +/-   ##
=======================================
  Coverage   98.34%   98.34%           
=======================================
  Files        1101     1101           
  Lines       58921    58924    +3     
=======================================
+ Hits        57943    57951    +8     
+ Misses        978      973    -5     
Impacted Files Coverage Δ
spec/datadog/tracing/contrib/qless/support/job.rb 94.28% <100.00%> (ø)
spec/datadog/tracing/contrib/redis/redis_spec.rb 99.50% <100.00%> (ø)
...ng/contrib/active_support/cache/instrumentation.rb 87.67% <0.00%> (+0.08%) ⬆️
spec/datadog/profiling/native_extension_spec.rb 97.87% <0.00%> (+1.06%) ⬆️
lib/datadog/core/diagnostics/environment_logger.rb 100.00% <0.00%> (+1.57%) ⬆️
...adog/tracing/contrib/sidekiq/client_tracer_spec.rb 100.00% <0.00%> (+2.08%) ⬆️
lib/datadog/core/workers/polling.rb 100.00% <0.00%> (+3.44%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@TonyCTHsu TonyCTHsu marked this pull request as ready for review November 11, 2022 08:38
@TonyCTHsu TonyCTHsu requested a review from a team November 11, 2022 08:38
Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but please remember to squash the history before merging so that a bunch of WIP commits and similar don't end up on master

.env Show resolved Hide resolved
spec/datadog/tracing/contrib/qless/support/job.rb Outdated Show resolved Hide resolved
docker-compose.yml Show resolved Hide resolved
@TonyCTHsu TonyCTHsu added dev/testing Involves testing processes (e.g. RSpec) dev/ci Involves CircleCI, GitHub Actions, or GitLab labels Nov 11, 2022
@TonyCTHsu TonyCTHsu merged commit 29a9517 into master Nov 11, 2022
@TonyCTHsu TonyCTHsu deleted the tonycthsu/fix-redis-spec branch November 11, 2022 15:27
@github-actions github-actions bot added this to the 1.6.0 milestone Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/ci Involves CircleCI, GitHub Actions, or GitLab dev/testing Involves testing processes (e.g. RSpec)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants