-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redis 6.2 image for CI #2364
Merged
Merged
Redis 6.2 image for CI #2364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TonyCTHsu
force-pushed
the
tonycthsu/fix-redis-spec
branch
2 times, most recently
from
November 10, 2022 15:04
afe8d19
to
d7e0ebc
Compare
Codecov Report
@@ Coverage Diff @@
## master #2364 +/- ##
=======================================
Coverage 98.34% 98.34%
=======================================
Files 1101 1101
Lines 58921 58924 +3
=======================================
+ Hits 57943 57951 +8
+ Misses 978 973 -5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ivoanjo
approved these changes
Nov 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but please remember to squash the history before merging so that a bunch of WIP commits and similar don't end up on master
TonyCTHsu
force-pushed
the
tonycthsu/fix-redis-spec
branch
from
November 11, 2022 14:37
60c2e5e
to
0572b49
Compare
TonyCTHsu
added
dev/testing
Involves testing processes (e.g. RSpec)
dev/ci
Involves CircleCI, GitHub Actions, or GitLab
labels
Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dev/ci
Involves CircleCI, GitHub Actions, or GitLab
dev/testing
Involves testing processes (e.g. RSpec)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Use Redis 6.2 image for CI. This would allow us to gradually testing newer gem version of redis and sidekiq
qless
is having issues with newer versions of redis. Establish a new old redis container for it. We should moveqless
tocontrib-old
in future. Because the gem is not actively maintained and has a couple of dependencies that are blocking other gems in the same appraisal group.