-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Redis configuration pin #2363
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2363 +/- ##
==========================================
- Coverage 98.34% 98.33% -0.01%
==========================================
Files 1102 1101 -1
Lines 58929 58938 +9
==========================================
+ Hits 57954 57959 +5
- Misses 975 979 +4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
marcotc
approved these changes
Nov 10, 2022
Merged
KJTsanaktsidis
added a commit
to zendesk/dd-trace-rb
that referenced
this pull request
Nov 16, 2022
zenspider
reviewed
Nov 16, 2022
Comment on lines
+24
to
+26
options[:redis_instance] = self | ||
|
||
super(options) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should prolly be
super(options.merge(redis_instance: self))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Current redis instrumentation is looking for pin on client object instead of the redis instance object. Hence it is different from the behavior the document claimed.
The PR implements patches provide mean to delegate the pin the be accessible to the client object.