Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Sinatra 3 #2360

Merged
merged 5 commits into from
Nov 11, 2022
Merged

Support Sinatra 3 #2360

merged 5 commits into from
Nov 11, 2022

Conversation

TonyCTHsu
Copy link
Contributor

What does this PR do?

Create Sinatra's appraisal group avoids the version update be blocked. Hence we could include Sinatra 3 into our test suite.

@TonyCTHsu TonyCTHsu requested a review from a team November 9, 2022 17:09
@TonyCTHsu TonyCTHsu self-assigned this Nov 9, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #2360 (bfd0c3b) into master (97885d7) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2360      +/-   ##
==========================================
+ Coverage   98.34%   98.36%   +0.02%     
==========================================
  Files        1102     1101       -1     
  Lines       58942    58873      -69     
==========================================
- Hits        57967    57911      -56     
+ Misses        975      962      -13     
Impacted Files Coverage Δ
...adog/tracing/contrib/sidekiq/client_tracer_spec.rb 97.91% <0.00%> (-2.09%) ⬇️
...adog/tracing/contrib/sidekiq/server_tracer_spec.rb 99.16% <0.00%> (-0.84%) ⬇️
...ng/contrib/active_support/cache/instrumentation.rb 87.67% <0.00%> (+0.08%) ⬆️
lib/datadog/core/diagnostics/environment_logger.rb 99.21% <0.00%> (+0.78%) ⬆️
lib/datadog/core/workers/polling.rb 100.00% <0.00%> (+3.44%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, does the Sinatra 3 integration need no changes? I somehow got the impression that we'd need to fix something to get it working.

Rakefile Show resolved Hide resolved
Appraisals Outdated Show resolved Hide resolved
Rakefile Outdated Show resolved Hide resolved
@TonyCTHsu TonyCTHsu merged commit b478593 into DataDog:master Nov 11, 2022
@TonyCTHsu TonyCTHsu deleted the feature/sinatra-3 branch November 11, 2022 08:41
@github-actions github-actions bot added this to the 1.6.0 milestone Nov 11, 2022
@TonyCTHsu
Copy link
Contributor Author

@ivoanjo I setup an integration application some weeks ago when Sinatra 3 is released. It just worked!

This PR is mainly addressing the fact that we are using Sinatra 3 in our test suite instead of 2.

@ivoanjo
Copy link
Member

ivoanjo commented Nov 11, 2022

@ivoanjo I setup an integration application some weeks ago when Sinatra 3 is released. It just worked!

This PR is mainly addressing the fact that we are using Sinatra 3 in our test suite instead of 2.

Awesome, glad to hear it! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants