-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Sinatra 3 #2360
Support Sinatra 3 #2360
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2360 +/- ##
==========================================
+ Coverage 98.34% 98.36% +0.02%
==========================================
Files 1102 1101 -1
Lines 58942 58873 -69
==========================================
- Hits 57967 57911 -56
+ Misses 975 962 -13
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity, does the Sinatra 3 integration need no changes? I somehow got the impression that we'd need to fix something to get it working.
@ivoanjo I setup an integration application some weeks ago when Sinatra 3 is released. It just worked! This PR is mainly addressing the fact that we are using Sinatra 3 in our test suite instead of 2. |
Awesome, glad to hear it! :) |
What does this PR do?
Create Sinatra's appraisal group avoids the version update be blocked. Hence we could include Sinatra 3 into our test suite.