Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport #2328 #2330

Merged
merged 4 commits into from
Oct 26, 2022
Merged

Backport #2328 #2330

merged 4 commits into from
Oct 26, 2022

Commits on Oct 26, 2022

  1. Avoid using problematic rspec-mocks 3.11.2 

    This version of rspec-mocks breaks CI for Ruby 2.7, 3.0 and 3.1 on
the following tests:

* ./spec/datadog/core/configuration_spec.rb:377 (Ruby 2.7)
* ./spec/datadog/core_spec.rb:35 (Ruby 2.7)
* ./spec/ddtrace/transport/http/builder_spec.rb:250 (Ruby 3.0, 3.1)

References:

* <https://app.circleci.com/pipelines/github/DataDog/dd-trace-rb/7560/workflows/24205733-d9fb-4781-962c-87499bad162d/jobs/280394>
* <https://app.circleci.com/pipelines/github/DataDog/dd-trace-rb/7560/workflows/24205733-d9fb-4781-962c-87499bad162d/jobs/280387>
* <https://app.circleci.com/pipelines/github/DataDog/dd-trace-rb/7560/workflows/24205733-d9fb-4781-962c-87499bad162d/jobs/280396>

I have not yet reported this upstream, but wanted to first unblock our
CI.
    @ivoanjo @lloeki
    ivoanjo authored and lloeki committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    fc1dc4b View commit details
    Browse the repository at this point in the history

  2. Avoid using pry-byebug on legacy rubies 

    We already have something similar on the `Gemfile` for the gem but did not copy it
to the integration apps.

Bundler on Ruby 2.2 gets confused sometimes and tries to install a
more modern `byebug`/`pry-byebug` than it should:
<https://app.circleci.com/pipelines/github/DataDog/dd-trace-rb/7563/workflows/84415e5e-c561-4312-8e18-ff4d59394471/jobs/280478>
    @ivoanjo @lloeki
    ivoanjo authored and lloeki committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    b366384 View commit details
    Browse the repository at this point in the history

  3. Handle REQUEST_URI with base url 

    This has been reported to happen on WEBrick, it may happen in other ways
depending on how the variable is set.
    @lloeki
    lloeki committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    e38bf92 View commit details
    Browse the repository at this point in the history

  4. Add unit testing

    @marcotc @lloeki
    marcotc authored and lloeki committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    edb2e3f View commit details
    Browse the repository at this point in the history