Fix URI::InvalidURIError
#2310
Merged
Fix URI::InvalidURIError
#2310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`env['REQUEST_URI']` is often only path, but in some environments (e.g. WEBrick) it containts the base url.
Codecov Report
@@ Coverage Diff @@
## master #2310 +/- ##
==========================================
- Coverage 97.58% 97.55% -0.03%
==========================================
Files 1094 1076 -18
Lines 57400 56792 -608
==========================================
- Hits 56015 55405 -610
- Misses 1385 1387 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@yujideveloper Thanks for this fix! I updated your branch with a couple of additional test cases. Otherwise, LGTM! |
lloeki
force-pushed
the
bugfix/invalid-uri-error
branch
from
e8b65e1
to
450c7cd
Compare
|
@lloeki |
|
Hey @yujideveloper, this has been released as part of 1.5.1, thank you for your contribution! |
|
@gingerlime FYI the fix in #2328 has been released in v1.5.2 |
|
Thanks so much @lloeki 👍 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This fixes
URI::InvalidURIErrorwhen it runs on WEBrick.This error introduced in v1.5.0 (#2265).
Additional Notes
env['REQUEST_URI']is often only path, but in some environments (e.g. WEBrick) it contains the base url (e.g.http://localhost:3000/foo/bar).https://github.com/ruby/webrick/blob/v1.7.0/lib/webrick/httprequest.rb#L423
https://github.com/ruby/webrick/blob/v1.7.0/lib/webrick/httprequest.rb#L218
https://github.com/ruby/webrick/blob/v1.7.0/lib/webrick/httprequest.rb#L484-L505
How to test the change?
Start rails server on WEBrick and access app via web browser (e.g.
http://localhost:300/foo).My environment is below: