[Resque] Cleanup after fork #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palazzem
force-pushed
the
rachel/testing-resque-perf
branch
from
467f6d7
to
05b0726
Compare
palazzem
approved these changes
Nov 2, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The child process created when Resque forks to work on a new job receives a copy of the parent process's buffers and
writer. This clears it out after the fork to ensure a clean slate and may help with performance. For example, if a span is not finished and aworkerthread not created, the buffers will never be cleared and the process will sleep in theshutdown!method until it times out at 5 seconds.Breaking Changes
No breaking changes