-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use full URL in http.url
tag
#2265
Merged
Merged
Commits on Sep 13, 2022
-
Adjust HTTP URL tags to comply with span tag unification RFC
- add a { base: :show } quantization option to enable the behaviour - align http.url with tag naming RFC (and Rack's #url) to include the complete request URL - drop http.base_url when not unneeded - preserve REQUEST_URI logic that differs from Rack's logic - add SCRIPT_NAME which was previously unhandled for PATH_INFO - append QUERY_STRING when using PATH_INFO to match REQUEST_URI
Configuration menu - View commit details
-
Copy full SHA for 3b2c316 - Browse repository at this point
Copy the full SHA 3b2c316View commit details -
Test query string quantization for PATH_INFO
Note: there seems to be leakage between spec cases, which made this test case flaky, with quantization option being set to show foo (example seed: 63620). The test case was previously unaffected by this leakage because it could not handle query strings.
Configuration menu - View commit details
-
Copy full SHA for f439d0e - Browse repository at this point
Copy the full SHA f439d0eView commit details -
Rack http.url tag now properly takes SCRIPT_NAME into account in the PATH_INFO case, consistently with REQUEST_URI. These expectations did not account for that.
Configuration menu - View commit details
-
Copy full SHA for ec68ba1 - Browse repository at this point
Copy the full SHA ec68ba1View commit details
Commits on Sep 16, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 7d4c742 - Browse repository at this point
Copy the full SHA 7d4c742View commit details -
Configuration menu - View commit details
-
Copy full SHA for 337ecb7 - Browse repository at this point
Copy the full SHA 337ecb7View commit details -
Preserve URL base in Quantization::HTTP.url by default
- restore the previous default behaviour of `Quantization::HTTP.url`. - also, make an effort to keep the Rack integration default as not preserving the URL base, restricting the transition code for the upcoming breaking change to that integration.
Configuration menu - View commit details
-
Copy full SHA for a741230 - Browse repository at this point
Copy the full SHA a741230View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5bbbffb - Browse repository at this point
Copy the full SHA 5bbbffbView commit details -
Configuration menu - View commit details
-
Copy full SHA for a5ff117 - Browse repository at this point
Copy the full SHA a5ff117View commit details
Commits on Sep 23, 2022
-
Disable Metrics/ClassLength cop
In practice this cop seems to be disabled as soon as we reach the limit.
Configuration menu - View commit details
-
Copy full SHA for 8c848ec - Browse repository at this point
Copy the full SHA 8c848ecView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.