Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use full URL in http.url tag #2265

Merged
merged 9 commits into from
Sep 23, 2022
Merged

Use full URL in http.url tag #2265

merged 9 commits into from
Sep 23, 2022

Commits on Sep 13, 2022

  1. Adjust HTTP URL tags to comply with span tag unification RFC

    - add a { base: :show } quantization option to enable the behaviour
    - align http.url with tag naming RFC (and Rack's #url) to include the
      complete request URL
    - drop http.base_url when not unneeded
    - preserve REQUEST_URI logic that differs from Rack's logic
    - add SCRIPT_NAME which was previously unhandled for PATH_INFO
    - append QUERY_STRING when using PATH_INFO to match REQUEST_URI
    lloeki committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    3b2c316 View commit details
    Browse the repository at this point in the history
  2. Test query string quantization for PATH_INFO

    Note: there seems to be leakage between spec cases, which made this test
    case flaky, with quantization option being set to show foo (example
    seed: 63620). The test case was previously unaffected by this leakage
    because it could not handle query strings.
    lloeki committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    f439d0e View commit details
    Browse the repository at this point in the history
  3. Adjust Sinatra expectations

    Rack http.url tag now properly takes SCRIPT_NAME into account in the
    PATH_INFO case, consistently with REQUEST_URI. These expectations did
    not account for that.
    lloeki committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    ec68ba1 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2022

  1. Silence Rubocop for this class

    lloeki committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    7d4c742 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    337ecb7 View commit details
    Browse the repository at this point in the history
  3. Preserve URL base in Quantization::HTTP.url by default

    - restore the previous default behaviour of `Quantization::HTTP.url`.
    - also, make an effort to keep the Rack integration default as not
      preserving the URL base, restricting the transition code for the
      upcoming breaking change to that integration.
    lloeki committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    a741230 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5bbbffb View commit details
    Browse the repository at this point in the history
  5. Remove unneeded super calls

    lloeki committed Sep 16, 2022
    Configuration menu
    Copy the full SHA
    a5ff117 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2022

  1. Disable Metrics/ClassLength cop

    In practice this cop seems to be disabled as soon as we reach the limit.
    lloeki committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    8c848ec View commit details
    Browse the repository at this point in the history