Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Fetch committer and author in Bitrise #2258

Merged
merged 1 commit into from
Sep 8, 2022

Conversation

albertvaka
Copy link
Contributor

What does this PR do?
Reads committer and author info from the env vars set by the CI provider.

Other tracers always set TAG_COMMIT_COMMITTER_EMAIL to the committer name. However there's a committer email variable we can use. I assume this was a typo that propagated from the spec to all tracers, so I've changed the spec to say we should use the email and fallback to the name if not available (just in case the spec was intentional because the email is not always available).

Motivation
These are in the CI spec but were missing from this tracer.

@albertvaka albertvaka requested a review from a team September 7, 2022 16:38
@marcotc marcotc added the ci-app CI product for test suite instrumentation label Sep 8, 2022
@marcotc marcotc merged commit 0e92706 into master Sep 8, 2022
@marcotc marcotc deleted the albertvaka/bitrise-fetch-author-and-commiter branch September 8, 2022 17:31
@github-actions github-actions bot added this to the 1.5.0 milestone Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-app CI product for test suite instrumentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants