Add http.useragent tag #2252
Merged
Add http.useragent tag #2252
+56
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcotc
approved these changes
Sep 8, 2022
While User-Agent is a header and can be included in the http.request_headers tag, it is not by default, and even if it were it oculd be removed from the list by the user. This unconditionally obtains the request header value and stores it in a dedicated tag.
lloeki
force-pushed
the
add-http-useragent-tag
branch
from
8af4ff0
to
1875ffd
Compare
|
Rebased + fixed conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add
http.useragenttag to capture and report the user agent that made an HTTP request to Rack-based applications.Motivation
While User-Agent is a header and can be included in the http.request_headers tag, it is not by default, and even if it were it could be removed from the list by the user.
This unconditionally obtains the request header value and stores it in a dedicated tag.
Additional Notes
This is a requirement for server-side ASM and is part of the APM tag standardization project.
How to test the change?