Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add http.useragent tag #2252

Merged
merged 1 commit into from
Sep 9, 2022
Merged

Add http.useragent tag #2252

merged 1 commit into from
Sep 9, 2022

Conversation

lloeki
Copy link
Contributor

@lloeki lloeki commented Sep 1, 2022

What does this PR do?

Add http.useragent tag to capture and report the user agent that made an HTTP request to Rack-based applications.

Motivation

While User-Agent is a header and can be included in the http.request_headers tag, it is not by default, and even if it were it could be removed from the list by the user.

This unconditionally obtains the request header value and stores it in a dedicated tag.

Additional Notes

This is a requirement for server-side ASM and is part of the APM tag standardization project.

How to test the change?

@lloeki lloeki requested a review from a team September 1, 2022 15:37
Copy link
Contributor

@TonyCTHsu TonyCTHsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍

While User-Agent is a header and can be included in the
http.request_headers tag, it is not by default, and even if it were it
oculd be removed from the list by the user.

This unconditionally obtains the request header value and stores it in a
dedicated tag.
@lloeki
Copy link
Contributor Author

lloeki commented Sep 9, 2022

Rebased + fixed conflicts.

@lloeki lloeki merged commit 64b0526 into master Sep 9, 2022
@lloeki lloeki deleted the add-http-useragent-tag branch September 9, 2022 15:17
@github-actions github-actions bot added this to the 1.5.0 milestone Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants