Drop truffleruby-head testing #1766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately the CI output right now needs to be binary: pass, or fail. Because we don't want to block contributions due to some breakage in truffleruby-head, we set the CI to `continue-on-error: true` aka never fail. But then we miss that truffleruby-head has been broken for quite some time. And even now that we know it, we won't be doing anything about it, since it's not a priority. So... this testing doesn't seem to be adding any value. Thus, I propose that we delete it. Hopefully, in the near future, we'll be able to add a stable truffleruby release to CI, and keep that one green (and care about when it breaks). See #1383 for ongoing tracking for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately the CI output right now needs to be binary: pass, or fail. Because we don't want to block contributions due to some breakage in truffleruby-head, we set the CI to
continue-on-error: trueaka never fail.But then we miss that truffleruby-head has been broken for quite some time. And even now that we know it, we won't be doing anything about it, since it's not a priority.
So... this testing doesn't seem to be adding any value. Thus, I propose that we delete it.
Hopefully, in the near future, we'll be able to add a stable truffleruby release to CI, and keep that one green (and care about when it breaks). See #1383 for ongoing tracking for this.