Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memoize environment tags to improve performance #1762

Merged
merged 1 commit into from
Nov 8, 2021
Merged

Memoize environment tags to improve performance #1762

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/datadog/ci/test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,10 @@ def self.set_tags!(span, tags = {})
span.context.origin = Ext::Test::CONTEXT_ORIGIN if span.context
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⬆️ GitHub doesn't allow me to comment on line 34, but is it just me or is it kinda weird that this method can receive an arbitrary tags hash, but does not actually set all of the tags in it, instead just cherry picking a few?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK it uses all tags passed in, but then adds/overwrites them with metadata. This should be an internal API anyway used only by the CI auto-instrumentation.

Datadog::Contrib::Analytics.set_measured(span)
span.set_tag(Ext::Test::TAG_SPAN_KIND, Ext::AppTypes::TEST)
Ext::Environment.tags(ENV).each { |k, v| span.set_tag(k, v) }

# Set environment tags
@environment_tags ||= Ext::Environment.tags(ENV)
@environment_tags.each { |k, v| span.set_tag(k, v) }

# Set contextual tags
span.set_tag(Ext::Test::TAG_FRAMEWORK, tags[:framework]) if tags[:framework]
Expand Down