Change the Redis client patch to use prepend #1743
Conversation
The current Redis patch uses alias_method which can cause conflicts with other libraries that use prepend to patch the same methods. This change moves the existing implementation to a separate Implementation module and uses prepend to patch methods instead of alias_method. Fixes #1686
| end | ||
|
|
||
| # InstanceMethods - implementing instrumentation | ||
| module InstanceMethods |
There was a problem hiding this comment.
The code in this module was moved verbatim from the patcher module except for the changes:
- replaced "without" method calls with super
- removed calls to alias_method and remove_method
| module Contrib | ||
| module Redis | ||
| # Instrumentation for Redis | ||
| module Instrumentation |
There was a problem hiding this comment.
The pattern for this module and the patcher module are copied from the http patcher.
|
|
||
| RSpec.describe Datadog::Contrib::Redis::Patcher do | ||
| describe '.patch' do | ||
| it 'adds Instrumentation methods to ancestors of Redis class' do |
There was a problem hiding this comment.
This spec pattern is from the ethon patch
Codecov Report
@@ Coverage Diff @@
## master #1743 +/- ##
==========================================
- Coverage 98.18% 98.18% -0.01%
==========================================
Files 934 935 +1
Lines 45196 45191 -5
==========================================
- Hits 44374 44369 -5
Misses 822 822
Continue to review full report at Codecov.
|
| module Contrib | ||
| module Redis | ||
| # Instrumentation for Redis | ||
| module Instrumentation |
delner
added
community
|
Thank you again, @justinhoward! 🙇 |
|
👋 Thank you again @justinhoward, https://github.com/DataDog/dd-trace-rb/releases/tag/v0.54.0 was just released, including this change. |
The current Redis patch uses alias_method which can cause conflicts with other libraries that use prepend to patch the same methods. This change moves the existing implementation to a separate Implementation module and uses prepend to patch methods instead of alias_method.
Fixes #1686