Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Active Job integration example code #1721

Merged
merged 1 commit into from
Oct 18, 2021
Merged

Fix Active Job integration example code #1721

merged 1 commit into from
Oct 18, 2021

Conversation

y-yagi
Copy link
Contributor

@y-yagi y-yagi commented Oct 18, 2021

Unfortunately, activejob doesn't exist.

require 'activejob'
# => LoadError: cannot load such file -- activejob

@y-yagi y-yagi requested a review from a team October 18, 2021 01:43
@codecov-commenter
Copy link

Codecov Report

Merging #1721 (e036276) into master (8f697cc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1721   +/-   ##
=======================================
  Coverage   98.18%   98.18%           
=======================================
  Files         934      934           
  Lines       45122    45122           
=======================================
  Hits        44301    44301           
  Misses        821      821

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f697cc...e036276. Read the comment docs.

@ivoanjo ivoanjo self-assigned this Oct 18, 2021
ivoanjo
ivoanjo approved these changes Oct 18, 2021
View reviewed changes
Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks a lot for the fix! Definitely an oversight 😅

@ivoanjo ivoanjo merged commit 09b7956 into DataDog:master Oct 18, 2021
@github-actions github-actions bot added this to the 0.54.0 milestone Oct 18, 2021
@y-yagi y-yagi deleted the fix-active-job-example branch October 18, 2021 22:57
@marcotc marcotc added the docs Involves documentation label Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivoanjo ivoanjo ivoanjo approved these changes

Assignees

@ivoanjo ivoanjo

Labels
docs Involves documentation
Projects
None yet
Milestone
0.54.0
Development

Successfully merging this pull request may close these issues.
4 participants
@y-yagi @codecov-commenter @ivoanjo @marcotc