Ensure special tags are always strings #1556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1556 +/- ##
=======================================
Coverage 98.23% 98.23%
=======================================
Files 878 878
Lines 42390 42407 +17
=======================================
+ Hits 41643 41660 +17
Misses 747 747
Continue to review full report at Codecov.
|
ericmustin
previously approved these changes
Jun 10, 2021
ynnadkrap
reviewed
Jun 11, 2021
ynnadkrap
approved these changes
Jun 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some Span tags have special handling in the Datadog Agent. Here's the list of these tags.
These tags have to always be reported as string Tags, not numerical Metrics.
One example of issues caused by setting these values as numerical is this:
In this case,
versionwill not correctly set the span version, thus not correctly updating the Datadog backend version value.This PR adds a check and ensures that these values are always string tags.