Add warning for incompatible dogstastd-ruby version #1544
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a one-time warning when
ddtrace
tries to instantiateDatadog::Statsd
with a version that can cause unbounded memory usage by leaking threads #1491.We've already updated our documentation instructing new users to not install
dogstastd-ruby
>= 5.0: #1533. Versions < 5.0 are confirmed safe.There's only one place in
ddtrace
whereDatadog::Statsd
instances are created, so the warning was placed at that point.