Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning for incompatible dogstastd-ruby version #1544

Merged
merged 1 commit into from
Jun 7, 2021

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Jun 4, 2021

This PR adds a one-time warning when ddtrace tries to instantiate Datadog::Statsd with a version that can cause unbounded memory usage by leaking threads #1491.

We've already updated our documentation instructing new users to not install dogstastd-ruby >= 5.0: #1533. Versions < 5.0 are confirmed safe.

There's only one place in ddtrace where Datadog::Statsd instances are created, so the warning was placed at that point.

@marcotc marcotc added the docs Involves documentation label Jun 4, 2021
@marcotc marcotc self-assigned this Jun 4, 2021
@marcotc marcotc requested a review from a team June 4, 2021 23:49
@codecov-commenter
Copy link

Codecov Report

Merging #1544 (75113a0) into master (75bec75) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1544   +/-   ##
=======================================
  Coverage   98.23%   98.24%           
=======================================
  Files         878      878           
  Lines       42337    42361   +24     
=======================================
+ Hits        41591    41616   +25     
+ Misses        746      745    -1     
Impacted Files Coverage Δ
lib/ddtrace/metrics.rb 96.87% <100.00%> (+0.23%) ⬆️
spec/ddtrace/metrics_spec.rb 100.00% <100.00%> (ø)
spec/ddtrace/profiling/ext/forking_spec.rb 100.00% <0.00%> (+0.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75bec75...75113a0. Read the comment docs.

@marcotc marcotc merged commit 529b37c into master Jun 7, 2021
@marcotc marcotc deleted the warning-dogstatsd-ruby branch June 7, 2021 18:46
@github-actions github-actions bot added this to the 0.50.0 milestone Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Involves documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants