Fix:Double initialization when auto instrumenting non-Rails applications #1497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were invoking
AutoInstrument.patch_alltwice for users of 'ddtrace/auto_instrument' that are not running a Rails application.This PR removes the unnecessary double call. Invoking
AutoInstrument.patch_allmultiple times has no ill effect, but creates unnecessary overhead.Also, a few of the tests were not running with the expected setup, as we were comparing an environment variable against a boolean value
ENV['TEST_AUTO_INSTRUMENT'] != true, while the returned value was always a string. This PR addresses that comparison.