Fix ActionPack instrumentation #starts_with? error #1489
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running ActionPack standalone (without Rails), ActionController instrumentation may raise
undefined method 'starts_with?'
when processing requests. This bug was discovered when running the Rails test suite with Datadog tracing enabled.This occurs because
starts_with?
is an ActiveSupport function, which may not be available. This pull request changes the function tostart_with?
which is the Ruby core library version, so it should be available outside Rails as well.This bug was not caught earlier because we have a gap in our test coverage over this controller instrumentation. This pull request tests for this specific bug, but does not fully address that gap: something we will want to do soon, possibly accompanying a refactor of the instrumentation itself.