-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add ActiveRecord SQL caller stack #1483
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1483 +/- ##
==========================================
- Coverage 98.22% 98.22% -0.01%
==========================================
Files 860 860
Lines 41271 41278 +7
==========================================
+ Hits 40538 40544 +6
- Misses 733 734 +1
Continue to review full report at Codecov.
|
Thanks for the pull request @sandboxws. Can you show us a screenshot of this in action? What does the tag look like? |
@delner of course! Will a screenshot of the Ruby hash output suffice or do you prefer a screenshot from an actual DataDog trace from a live product ( i.e. from a DataDog dashboard )? |
Description
Adds an additional
query_caller_stack
tag to ActiveRecord spans. The new tag includes the Rails' caller stack that triggered the SQL execution. Including the query caller stack as part of the span significantly improves the ability to trace down slow queries reported by DataDog to the part of the code from which it originated and ultimately fixing the query.TODO