Add trace_completed event to Tracer #1458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delner
added
core
delner
force-pushed
the
feature/trace_completed_event
branch
from
dc7c56e
to
a618d64
Compare
delner
force-pushed
the
feature/trace_completed_event
branch
from
a618d64
to
34e2fa3
Compare
marcotc
approved these changes
Apr 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #1390
This pull request adds a
trace_completedevent that is triggered whenever the tracer completes a trace. It is meant to allow fan-out of traces, such that other things may be done with them (logged to file, emit metrics, etc.) In the future, the writer will subscribe to this event to ingest traces.