Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate ActionView::Utils tests to RSpec #1432

Merged
merged 1 commit into from
Mar 29, 2021
Merged

Migrate ActionView::Utils tests to RSpec #1432

merged 1 commit into from
Mar 29, 2021

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Mar 26, 2021

Same test, different testing framework.

@marcotc marcotc added the dev/testing Involves testing processes (e.g. RSpec) label Mar 26, 2021
@marcotc marcotc self-assigned this Mar 26, 2021
@marcotc marcotc requested a review from a team March 26, 2021 22:14
@codecov-io
Copy link

Codecov Report

Merging #1432 (73ff8c6) into master (000e167) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1432   +/-   ##
=======================================
  Coverage   98.13%   98.14%           
=======================================
  Files         771      772    +1     
  Lines       36901    36926   +25     
=======================================
+ Hits        36214    36241   +27     
+ Misses        687      685    -2     
Impacted Files Coverage Δ
spec/ddtrace/contrib/action_view/utils_spec.rb 100.00% <100.00%> (ø)
lib/ddtrace/contrib/action_view/utils.rb 100.00% <0.00%> (+14.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 000e167...73ff8c6. Read the comment docs.

Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙇

@marcotc marcotc merged commit 62a019f into master Mar 29, 2021
@marcotc marcotc deleted the less-minitest branch March 29, 2021 16:23
@github-actions github-actions bot added this to the 0.47.0 milestone Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/testing Involves testing processes (e.g. RSpec)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants