Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a test running under our
expect_in_fork
test helper fails, it creates this output:This message unfortunately only tells us that the child process exited with a status non-zero.
This error happens to be a flaky issue today: https://app.circleci.com/pipelines/github/DataDog/dd-trace-rb/2998/workflows/5c01a51a-b03d-4bfb-a32d-5015716207df/jobs/120042/parallel-runs/2
This PR captures the STDERR output inside the forked process and reports that output when the fork exists with a non-zero status. I introduced a fake failure (
expect(1).to be(2)
) at linetrace_writer_spec.rb:689
for this example, inside the forked block: