Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore coverage report for skipped benchmark tests #1299

Merged
merged 1 commit into from
Jan 5, 2021

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Jan 5, 2021

These performance tests are not run in CI (before { skip('Performance test does not run in CI.') }), and thus count negatively towards our code coverage report.

This PR skips coverage collection for these performance tests.

@marcotc marcotc requested a review from a team January 5, 2021 19:07
@marcotc marcotc merged commit 57b8f14 into master Jan 5, 2021
@marcotc marcotc deleted the coverage-skip-benchmark branch January 5, 2021 19:26
@marcotc marcotc self-assigned this Jan 5, 2021
@marcotc marcotc added the dev/testing Involves testing processes (e.g. RSpec) label Jan 5, 2021
@github-actions github-actions bot added this to the 0.44.0 milestone Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/testing Involves testing processes (e.g. RSpec)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants