Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade CI to Ruby 3.0 release #1296

Merged
merged 5 commits into from
Jan 4, 2021
Merged

Upgrade CI to Ruby 3.0 release #1296

merged 5 commits into from
Jan 4, 2021

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Jan 4, 2021

This now tests ddtrace using the final release version of Ruby 3.0.0.

Before we were using 3.0.0-preview2.

A few test dependency tweaks:

  • crack has released a version compatible with Ruby 3.0, unpinning it.
  • webrick is not bundled by default since Ruby 3.0, added the explicit gem now.
  • No progress on both protobuf and rdkafka regarding Ruby 3.0 support.

@marcotc marcotc added the dev/ci Involves CircleCI, GitHub Actions, or GitLab label Jan 4, 2021
@marcotc marcotc self-assigned this Jan 4, 2021
@marcotc marcotc requested a review from a team January 4, 2021 17:53
@codecov-io
Copy link

Codecov Report

Merging #1296 (a670ca1) into master (1f8551c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1296   +/-   ##
=======================================
  Coverage   97.79%   97.79%           
=======================================
  Files         751      751           
  Lines       35681    35681           
=======================================
  Hits        34896    34896           
  Misses        785      785           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f8551c...a670ca1. Read the comment docs.

ericmustin
ericmustin previously approved these changes Jan 4, 2021
Copy link
Contributor

@ericmustin ericmustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: 3️⃣

@marcotc marcotc merged commit 98ffbea into master Jan 4, 2021
@marcotc marcotc deleted the ruby-3.0-release branch January 4, 2021 22:16
@github-actions github-actions bot added this to the 0.44.0 milestone Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/ci Involves CircleCI, GitHub Actions, or GitLab
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants