Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Tracer#trace start_time type documentation #1268

Merged
merged 1 commit into from
Dec 2, 2020
Merged

Fix Tracer#trace start_time type documentation #1268

merged 1 commit into from
Dec 2, 2020

Commits on Nov 30, 2020

  1. Fix Tracer#trace start_time type documentation 

    Fixes #1264

This PR updates the required type for the `Datadog::Tracer#trace(start_time:)` option.

The type required is a Ruby [Time](https://ruby-doc.org/stdlib-2.7.2/libdoc/time/rdoc/Time.html) object, while the documentation erroneously requested an `Integer`.

As as follow up, I suggest we move most of this documentation to our published API docs: https://www.rubydoc.info/github/DataDog/dd-trace-rb/Datadog/Tracer#trace-instance_method. This allows us to keep the documentation close to implementation, and prevent information drift between the two.
    @marcotc
    marcotc authored Nov 30, 2020
    Configuration menu
    Copy the full SHA
    24299dc View commit details
    Browse the repository at this point in the history