Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip vendored files in coverage report #1257

Merged
merged 1 commit into from
Nov 19, 2020
Merged

Skip vendored files in coverage report #1257

merged 1 commit into from
Nov 19, 2020

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Nov 18, 2020

We have a few files in our repository that are not maintained by us (lib/ddtrace/vendor/active_record/connection_specification.rb, lib/ddtrace/contrib/redis/vendor/resolver.rb).

Despite that, we have them as "undertested" in our coverage reports.

This PR excludes vendored files from our coverage reports.

@marcotc marcotc added the dev/ci Involves CircleCI, GitHub Actions, or GitLab label Nov 18, 2020
@marcotc marcotc requested a review from a team November 18, 2020 21:28
@marcotc marcotc self-assigned this Nov 18, 2020
@marcotc marcotc merged commit 409ec65 into master Nov 19, 2020
@marcotc marcotc deleted the test/skip-vendor branch November 19, 2020 18:46
@github-actions github-actions bot added this to the 0.44.0 milestone Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/ci Involves CircleCI, GitHub Actions, or GitLab
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants