Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access active correlation by thread #1200

Merged
merged 2 commits into from
Oct 6, 2020
Merged

Conversation

delner
Copy link
Contributor

@delner delner commented Oct 6, 2020

Currently Datadog.tracer.active_correlation provides a Datadog::Correlation::Identifier for the current thread: it is not possible to obtain the correlation for an arbitrary thread on which a trace might be running.

This pull request allows a key (aka thread) to be provided when the active correlation is accessed, so that the correlation matching that key can be returned. This will be useful for profiling or logging when producing correlations from threads other than the current.

@delner delner added core Involves Datadog core libraries feature Involves a product feature labels Oct 6, 2020
@delner delner requested review from marcotc, ericmustin and a team October 6, 2020 18:34
@delner delner self-assigned this Oct 6, 2020
Copy link
Member

@marcotc marcotc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@delner delner merged commit a221336 into master Oct 6, 2020
@delner delner deleted the feature/correlation_per_thread branch October 6, 2020 19:02
@ericmustin ericmustin added this to the 0.42.0 milestone Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Involves Datadog core libraries feature Involves a product feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants