Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable coverage report for benchmarks #1176

Merged
merged 1 commit into from
Sep 16, 2020
Merged

Disable coverage report for benchmarks #1176

merged 1 commit into from
Sep 16, 2020

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Sep 15, 2020

Collecting code coverage during benchmarks slows down the execution.

This PR disables coverage collection on all tests run from a benchmark directory.

@marcotc marcotc added the performance Involves performance (e.g. CPU, memory, etc) label Sep 15, 2020
@marcotc marcotc requested a review from a team September 15, 2020 21:47
@marcotc marcotc self-assigned this Sep 15, 2020
brettlangdon
brettlangdon approved these changes Sep 16, 2020
View reviewed changes
Copy link
Member

@brettlangdon brettlangdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but how will we know if our benchmarks cover everything?

@marcotc
Copy link
Member Author

marcotc commented Sep 16, 2020 via email

@brettlangdon
Copy link
Member

Our benchmarks won't cover everything, only parts that require special attention. It's there any reason you like to benchmark everything?

@marcotc sorry, I should have put /s at the end, was just making a joke 😆

@marcotc marcotc merged commit d0c2880 into master Sep 16, 2020
@marcotc marcotc deleted the perf/disable-coverage-on-benchmarks branch September 16, 2020 18:56
@marcotc
Copy link
Member Author

marcotc commented Sep 16, 2020

@brettlangdon Poe's law

@marcotc marcotc added this to the 0.41.0 milestone Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericmustin ericmustin ericmustin approved these changes

@brettlangdon brettlangdon brettlangdon approved these changes

Assignees

@marcotc marcotc

Labels
performance Involves performance (e.g. CPU, memory, etc)
Projects
None yet
Milestone
0.41.0
Development

Successfully merging this pull request may close these issues.
3 participants
@marcotc @brettlangdon @ericmustin