Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci:Remove gitlab deployment when not applicable #1160

Merged
merged 1 commit into from
Sep 4, 2020

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Aug 31, 2020

This removes the Gitlab internal CI check from all Github commits, unless it's applicable: only master commits and manually triggered Gitlab job runs will show up here on Github.
Screen Shot 2020-08-31 at 3 43 05 PM

This will allow our commits to come back into a ✅ state when everything passes.

@marcotc marcotc added the dev/ci Involves CircleCI, GitHub Actions, or GitLab label Aug 31, 2020
@marcotc marcotc requested a review from a team August 31, 2020 19:44
@marcotc marcotc self-assigned this Aug 31, 2020
Copy link
Contributor

@ericmustin ericmustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@marcotc marcotc merged commit 84dcbd6 into master Sep 4, 2020
@marcotc marcotc deleted the ci/avoid-gitlab-status-hang branch September 4, 2020 19:29
@marcotc marcotc added this to the 0.40.0 milestone Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/ci Involves CircleCI, GitHub Actions, or GitLab
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants