Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix runtime metrics not starting after #write #1010

Merged
merged 1 commit into from
Apr 20, 2020
Merged

Fix runtime metrics not starting after #write #1010

merged 1 commit into from
Apr 20, 2020

Conversation

delner
Copy link
Contributor

@delner delner commented Apr 17, 2020

After refactoring the runtime metrics worker out of Writer in #1004, the worker was not lazily starting after a trace was written, preventing runtime metrics from being emitted.

This pull request changes Workers::RuntimeMetrics#associate_with_span to now start the worker when called.

@delner delner added bug Involves a bug core Involves Datadog core libraries labels Apr 17, 2020
@delner delner added this to the 0.35.0 milestone Apr 17, 2020
@delner delner requested review from marcotc, brettlangdon and a team April 17, 2020 21:21
@delner delner self-assigned this Apr 17, 2020
@delner delner merged commit d7bd6d9 into master Apr 20, 2020
@delner delner deleted the fix/runtime_metrics_lazy_start branch April 20, 2020 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcotc marcotc marcotc approved these changes

@brettlangdon brettlangdon Awaiting requested review from brettlangdon

Assignees

@delner delner

Labels
bug Involves a bug core Involves Datadog core libraries
Projects
None yet
Milestone
0.35.0
Development

Successfully merging this pull request may close these issues.
2 participants
@delner @marcotc