Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unlock Bundler version for testing #1009

Merged
merged 1 commit into from
Apr 22, 2020
Merged

Unlock Bundler version for testing #1009

merged 1 commit into from
Apr 22, 2020

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Apr 17, 2020

The version of bundler we use for testing in CircleCI was locked for Ruby 2.7 due to a bug which seemed to be related to the Appraisal gem.

That issue was addressed in the upstream ruby docker image, so new docker images we build for CI will work correctly with new versions of bundler.

This PR unlocks the version of bundler so we can continue testing with the latest available version. One thing to note is that the version of bundler we use in CI is locked at the time we publish the image, so we are not actually constantly upgrading bundler. This PR then publishes a new version of the Ruby 2.7 CI image, to allow it to upgrade to the latest version.

@marcotc marcotc added dev/testing Involves testing processes (e.g. RSpec) dev/ci Involves CircleCI, GitHub Actions, or GitLab labels Apr 17, 2020
@marcotc marcotc requested a review from a team April 17, 2020 21:13
@marcotc marcotc self-assigned this Apr 17, 2020
@delner
Copy link
Contributor

delner commented Apr 20, 2020

CI 2.7 build still looks like it has a Bundler issue, this time when running Grape tests?

@marcotc
Copy link
Member Author

marcotc commented Apr 20, 2020

Thank you for the tip @delner, I addressed the issue (CI had a bad cache gemset from another build, starting a clean rebuild job fixed it).
Could you take a look again when you have some time?

@marcotc marcotc merged commit 3b2a0db into master Apr 22, 2020
@marcotc marcotc deleted the ci/unlock-bundler branch April 22, 2020 17:34
@marcotc marcotc added this to the 0.35.0 milestone Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/ci Involves CircleCI, GitHub Actions, or GitLab dev/testing Involves testing processes (e.g. RSpec)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants