Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear wording Faraday default integration #1005

Merged
merged 1 commit into from
Apr 15, 2020

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Apr 14, 2020

This PR makes it more clear that configuring each Faraday connection is not necessary anymore.

Because this was necessary in past versions, our documentation still had language that suggested this is still necessary.

The language used to explain how to override is the same we use when documenting our MongoDB integration overrides.

@marcotc marcotc added the docs Involves documentation label Apr 14, 2020
@marcotc marcotc requested a review from a team April 14, 2020 20:24
@marcotc marcotc self-assigned this Apr 14, 2020
Copy link
Contributor

@delner delner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@marcotc marcotc merged commit d7aba16 into master Apr 15, 2020
@marcotc marcotc deleted the doc/faraday-override-wording branch April 15, 2020 21:01
@marcotc marcotc added this to the 0.35.0 milestone Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Involves documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants